Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Enables the eslint require-await rule after noticing some spots where
async
was used unexpectedly.This is disabled in the ni eslint rules due to airbnb's configuration which I think is not well justified. At least in nimble we should prefer async-await syntax AND prefer to not mix async and promise syntax. Enabling this rule helps prevent mixing syntaxes and so far with enabling it helped prevent introducing unnecessary / unexpected async functions.
👩💻 Implementation
Enabled
require-await
or@typescript-eslint/require-await
in each.eslintrs.jc
file. The rule found additional places in source where the use ofasync
was unnecessary.🧪 Testing
Rely on CI.
✅ Checklist